Add proper Pearl of Tsoatha support - #10236
Open
vaisest wants to merge 10 commits into
Open
Conversation
vaisest
changed the title
vaisest
commented
Aug 17, 2026
| t_insert(node.grantedSkills, { | ||
| skillId = skill.skillId, | ||
| level = skill.level, | ||
| noSupports = true, |
Contributor
Author
There was a problem hiding this comment.
Technically it seems that this should hide the "You cannot socket gems..." label on the skills tab, but it seems like this feature doesn't work anyway on beta so I'm not sure how much of a problem this is
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
This adds proper pearl of tsoatha support. This includes
appliesToGrantedSkillsto the on the ExtraSupport mod, and using that to allow it as an exception.It seems that existing ExtraSupport code didn't have protections for duplicate support gems. I had to work around this, and there's a small caveat that they don't show up as (superseded) in the skills tab.
Steps taken to verify a working solution:
Link to a build that showcases this PR:
Before screenshot:
After screenshot:
Note that I removed the elem dam mod here: